Feature test usart into release #12
Conversation
pull release into master, feature test_usart was added
test/Makefile
Outdated
| @@ -9,10 +9,12 @@ | |||
| ############################################################################# | |||
|
|
|||
| # source files in this project (main.cpp is automatically assumed) | |||
| SOURCES := $(wildcard ../code/src/*.cpp) | |||
| #SOURCES := $(wildcard ../code/src/*.cpp) | |||
There was a problem hiding this comment.
gone by 85fdce9
code/headers/test_usart.hpp
Outdated
|
|
||
|
|
||
| public: | ||
|
|
||
| test_usart_c(unsigned int baudrate, uart_ports_c usart_port); | ||
| test_usart_c(); | ||
|
|
||
| /// @brief does not actualy disable anything |
There was a problem hiding this comment.
this comment is wrong btw. The function name is enable
There was a problem hiding this comment.
edited in 85fdce9
code/headers/test_usart.hpp
Outdated
| @@ -47,5 +48,17 @@ namespace r2d2 { | |||
| ///@return unsigned int always 1 | |||
There was a problem hiding this comment.
this doesn't always return 1 anymore
There was a problem hiding this comment.
edited in 85fdce9
code/src/test_usart.cpp
Outdated
| } | ||
| } | ||
|
|
||
| void test_usart_c::set_receive_byte(const uint8_t byte){ |
There was a problem hiding this comment.
this function sounds like the byte i set here will be the only byte that will be in the receive_buffer. Maybe a name change to something like add_receive_byte() is better here
There was a problem hiding this comment.
or a clear before the push is oke as well i guess.
There was a problem hiding this comment.
was changed in 85fdce9
| return receive_buffer.copy_and_pop(); | ||
| } | ||
|
|
||
| bool test_usart_c::char_available() { |
There was a problem hiding this comment.
What is the difference between char_available() and available()? seems a bit redundant they return the exact same atm
There was a problem hiding this comment.
char_available returns true if char is available, available returns the amound of bytes available
There was a problem hiding this comment.
But both char_available() and available() return !receive_buffer.empty() that is unintended then i guess
| #include <test_usart.hpp> | ||
| #include <uart_ports.hpp> | ||
|
|
||
| TEST_CASE("test_usart_c sends","[test_usart_c]"){ |
There was a problem hiding this comment.
maybe a test with the set_receive_string() and the set_receive_bytes()?
There was a problem hiding this comment.
were added in 85fdce9
No description provided.